Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add_plugin.md #210

Merged
merged 6 commits into from
Mar 16, 2022
Merged

Update add_plugin.md #210

merged 6 commits into from
Mar 16, 2022

Conversation

justinegeffen
Copy link
Contributor

@justinegeffen justinegeffen added the 2: Dev Review Requires review by a core committer label Aug 2, 2021
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping the docs in sync 👍

.github/ISSUE_TEMPLATE/add_plugin.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/add_plugin.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/add_plugin.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/add_plugin.md Show resolved Hide resolved
@justinegeffen
Copy link
Contributor Author

@hanzei, this file is now aligned with: mattermost/mattermost-developer-documentation#747.

.github/ISSUE_TEMPLATE/add_plugin.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/add_plugin.md Show resolved Hide resolved
@hanzei hanzei added Work In Progress Not yet ready for review and removed 2: Dev Review Requires review by a core committer labels Dec 10, 2021
@justinegeffen justinegeffen added 2: Dev Review Requires review by a core committer and removed Work In Progress Not yet ready for review labels Jan 26, 2022
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that mattermost/mattermost-developer-documentation#747 was closed, is this PR still valid? The docs in the repo and the dev docs should be in sync.

@justinegeffen justinegeffen added 1: PM Review Requires review by a product manager and removed 2: Dev Review Requires review by a core committer labels Mar 16, 2022
Copy link
Contributor

@aaronrothschild aaronrothschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


**Documentation requirements (checked by a Technical Writer)**

- [ ] The plugin must include detailed usage documentation with at least one screenshot of the plugin in action, list of features, and a development guide. This is typically a `README` file or a landing page on the web. The link to the documentation is set as `homepage_url` in the manifest. A great example is the [`README` of the GitHub plugin](https://github.com/mattermost/mattermost-plugin-github/blob/master/README.md). Typical components of documentation include:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put the development guide as a separate linked .MD file? Of the hundreds of people who read it, only a small fraction will ever custom code or contribute. and ittakes up a large section. I'd be happy to put a "How to Contribute" link higher up in the doc more prominently if it was linked out. Otherwise, I say sink it to the bottom of the readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this, I agree with you. It's too wordy. I believe we have this documented elsewhere but if not it certainly can be moved. I'll address this in a separate PR. Thank you!

@justinegeffen justinegeffen merged commit ac7ff39 into master Mar 16, 2022
@justinegeffen justinegeffen deleted the justinegeffen-patch-1 branch March 16, 2022 14:40
@justinegeffen justinegeffen added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager labels Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants